This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Incremental smoke test changes #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrebriggs
commented
Nov 18, 2019
andrebriggs
commented
- Fixed issue around SP_PASS variable not being expanded in shell script and blocking test.
- Added additional validation of environment variables.
- Typo fix
[skip ci]
Test changes
andrebriggs
requested review from
evanlouie,
jmspring,
samiyaakhtar and
yradsmikham
mtarng
approved these changes
Nov 18, 2019
bnookala
approved these changes
Nov 18, 2019
samiyaakhtar
approved these changes
Nov 18, 2019
edaena
approved these changes
Nov 18, 2019
yradsmikham
approved these changes
Nov 18, 2019
evanlouie
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.