This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Removing PAT being logged in buildDefinitions #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaena
approved these changes
Nov 21, 2019
andrebriggs
reviewed
Nov 21, 2019
Collaborator
andrebriggs
left a comment
andrebriggs
left a comment
There was a problem hiding this comment.
@mtarng is the main change that we are changing from logger.info to logger.debug?
Collaborator
Author
|
@andrebriggs no, we're removing where we're logging the buildDefiniton at all, because if you run spk with the verbose -v flag, then it'll still get logged out in debug. |
bnookala
approved these changes
Nov 21, 2019
andrebriggs
approved these changes
Nov 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes microsoft/bedrock#817