This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Adding pipeline variable to specify build.sh url #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtarng
changed the title
bnookala
suggested changes
Nov 21, 2019
src/commands/project/pipeline.ts
Outdated
| repoUrl = getRepositoryUrl(gitOriginUrl), | ||
| hldUrl = azure_devops && azure_devops.hld_repository | ||
| hldUrl = azure_devops && azure_devops.hld_repository, | ||
| buildScriptUrl = "https://raw.githubusercontent.com/Microsoft/bedrock/master/gitops/azure-devops/build.sh" |
Member
There was a problem hiding this comment.
make this a const variable that is exported from somewhere
bnookala
approved these changes
Nov 21, 2019
edaena
approved these changes
Nov 21, 2019
bnookala
pushed a commit
to bnookala/spk
that referenced
this pull request
Dec 12, 2019
* Adding buildScriptUrl for each pipeline as a EnvVar and Pipeline Variable * logic + docs, confirmed working via smoketest, need to fix unit tests * updating unit tests * Adding constants * missed 2...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/bedrock#804