Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Variable Groups bug fix #200

Merged
sarath-p merged 4 commits into from
Jan 23, 2020
Merged

Variable Groups bug fix #200

sarath-p merged 4 commits into from
Jan 23, 2020

Conversation

@sarath-p
Copy link
Contributor

@sarath-p sarath-p commented Jan 23, 2020

dennisseah
dennisseah reviewed Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@dennisseah dennisseah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

@andrebriggs andrebriggs self-requested a review January 23, 2020 21:09
samiyaakhtar
samiyaakhtar reviewed Jan 23, 2020
View reviewed changes
@sarath-p sarath-p merged commit 60c3cca into master Jan 23, 2020
@andrebriggs andrebriggs deleted the vg branch January 25, 2020 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bnookala bnookala Awaiting requested review from bnookala

@andrebriggs andrebriggs Awaiting requested review from andrebriggs

3 more reviewers

@samiyaakhtar samiyaakhtar samiyaakhtar approved these changes

@dennisseah dennisseah dennisseah approved these changes

@mtarng mtarng mtarng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SPK smoke tests failure due to variables not populated in variable group

5 participants

@sarath-p @samiyaakhtar @dennisseah @mtarng