This repository was archived by the owner on Apr 13, 2020. It is now read-only.
Fixing the noop broken project lifecycle pipeline #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnookala
approved these changes
Jan 23, 2020
mtarng
changed the title
evanlouie
approved these changes
Jan 23, 2020
Collaborator
|
Looks good. @mtarng I assume you tested locally? Also why are we removing the |
andrebriggs
approved these changes
Jan 23, 2020
Collaborator
Author
|
@andrebriggs hld repo url is now configured in the variable group for the project. |
Collaborator
Author
|
Adding minor change. Apparently isValidConfig was never being used to check for service pipelines. There exists unit tests for it already. |
sarath-p
approved these changes
Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes microsoft/bedrock#899