Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

[REFACTOR] project init command #203

Merged
dennisseah merged 41 commits into from
Jan 27, 2020
Merged

[REFACTOR] project init command #203

dennisseah merged 41 commits into from
Jan 27, 2020

Conversation

@dennisseah
Copy link
Collaborator

@dennisseah dennisseah commented Jan 23, 2020 •
edited
Loading

  1. have command decoration to a separation JSON file
  2. improve test coverage from 60 to 80%.
  3. create helper functions for creating random dir
  4. create helper functions for checking if file exists
  5. remove unused function (ls) in init.ts
  6. proper exit code for init.ts
  7. make reduce function in init.ts more readable

successfully ran validations.sh

Related to microsoft/bedrock#885

dennisseah and others added 30 commits January 16, 2020 16:47
@dennisseah
replace any with interface
fc20a31
@dennisseah
correct the type definition for IVariableGroupDataVariable[]
c330a2e
@dennisseah
Merge remote-tracking branch 'upstream/master'
f5a6a68
@dennisseah
Merge remote-tracking branch 'upstream/master'
d3d0f39
@dennisseah
Merge remote-tracking branch 'upstream/master'
d1820a3
@dennisseah
[REFACTOR] making code compact
c22dbe6
@dennisseah
Merge remote-tracking branch 'upstream/master'
9c5c78e
@dennisseah
add test to create-variable-group command
0ee2c8a
@dennisseah
breaking larger function in scaffold class into smaller one, so we ca…
7ed0354 
…n add tests
@dennisseah
Merge remote-tracking branch 'upstream/master'
72a865e
@dennisseah
simplier commander interface
f1361db
@dennisseah
using type guard in hasValue function
8cbda1f
@dennisseah
incorporate Evan's feedback
1762cb2
@dennisseah
fix jsdoc
d53273d
@dennisseah
fixed the problem where definition.yaml file is not created
07d5658
@yradsmikham
Merge branch 'master' into master
8e999e8
@dennisseah
Merge remote-tracking branch 'upstream/master'
6584b77
@dennisseah
Merge branch 'master' of https://github.com/dennisseah/spk
f4fe956
@dennisseah
[REFACTOR] commands/hld/init.ts and add tests
bd04d9c 
1. move the command decoration out to a JSON file
2. standardized on command decorator function name, initCommandDecorator -> commandDecorator
3. added support for having default values in command builder
4. added tests to boost the coverage from 59% to 89%
5. create helper functions in tests so test code is more manage-able
@dennisseah
modified code to make sure that log is flushed before the command exit
f9d18ce
@dennisseah
Merge remote-tracking branch 'upstream/master'
a1d4990
@dennisseah
adding missing Promise<void> return type
23490ff
@dennisseah
Merge remote-tracking branch 'upstream/master'
48afdc3
@dennisseah
Merge remote-tracking branch 'upstream/master'
5462680
@dennisseah
Merge remote-tracking branch 'upstream/master'
454d462
@dennisseah
Merge remote-tracking branch 'upstream/master'
7edbdca
@dennisseah
[REFACTOR] project init command
11f21b5 
1. have command decoration to a separation JSON file
2. improve test coverage from 60 to 80%.
3. create helper functions for creating random dir
4. create helper functions for checking if file exists
5. remove unused function (ls) in init.ts
6. proper exit code for init.ts
7. make reduce function in init.ts more readable

successfully ran validations.sh
@dennisseah
have ringName = uuid() in test
97f816e
@dennisseah
fix typo
93bca78
@dennisseah
remove hld-lifecycle.yaml
510125f
@andrebriggs andrebriggs self-requested a review January 25, 2020 20:43
@dennisseah dennisseah requested a review from evanlouie January 27, 2020 15:38
@andrebriggs
Copy link
Collaborator

andrebriggs commented Jan 27, 2020

@sarath-p @mtarng

sarath-p
sarath-p approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@sarath-p sarath-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mtarng
Copy link
Collaborator

mtarng commented Jan 27, 2020 •
edited
Loading

Do you think src/lib/ioUtil.ts would only be used to unit tests? If so, could we move it under src/test/ioUtil.ts? @dennisseah

@dennisseah
Copy link
Collaborator Author

dennisseah commented Jan 27, 2020

Do you think src/lib/ioUtil.ts would only be used to unit tests? If so, could we move it under src/test/ioUtil.ts? @dennisseah

I hope to not restrict it to tests. Thanks

@dennisseah dennisseah merged commit 5706003 into CatalystCode:master Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bnookala bnookala Awaiting requested review from bnookala

@evanlouie evanlouie Awaiting requested review from evanlouie

3 more reviewers

@sarath-p sarath-p sarath-p approved these changes

@andrebriggs andrebriggs andrebriggs approved these changes

@mtarng mtarng mtarng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dennisseah @andrebriggs @mtarng @sarath-p @yradsmikham