Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@dennisseah
Copy link
Collaborator

Related to microsoft/bedrock#885

  1. move command declaration to a JSON file
  2. call common exit function
  3. added test to boost coverage to 90%-ish
  4. added better validation for port
  5. have an interface for command values to avoid passing many values to functions

@mtarng mtarng requested a review from bnookala January 30, 2020 22:35
Copy link
Contributor

@sarath-p sarath-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dennisseah
Copy link
Collaborator Author

@evanlouie, can you let me know what are the changes as you have a change requested. thanks

@dennisseah dennisseah merged commit eb6c58d into master Jan 31, 2020
@dennisseah dennisseah deleted the refactorServiceCreateTs branch January 31, 2020 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants