Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@dennisseah
Copy link
Collaborator

@mtarng
Copy link
Collaborator

mtarng commented Feb 14, 2020

Why do we need to rename the folder? Also documentation should be fine for plural form.

@dennisseah
Copy link
Collaborator Author

Why do we need to rename the folder? Also documentation should be fine for plural form.

This is mentioned in Slack #spk yesterday and we have 24 hours for people to read this microsoft/bedrock#976. I am renaming docs -> documentations both are plural. Please let me know your concern. thanks

@mtarng
Copy link
Collaborator

mtarng commented Feb 14, 2020

Looks like this is breaking a few image and relative links within our docs too.

spk diagram: https://github.com/CatalystCode/spk/blob/mvDos/README.md
First link under: https://github.com/CatalystCode/spk/tree/mvDos#getting-started
spk resources diagram right above link: https://github.com/CatalystCode/spk/blob/mvDos/documentations/project-service-management-guide.md#requirements

There might be a few others too.

@dennisseah
Copy link
Collaborator Author

Looks like this is breaking a few image and relative links within our docs too.

spk diagram: https://github.com/CatalystCode/spk/blob/mvDos/README.md
First link under: https://github.com/CatalystCode/spk/tree/mvDos#getting-started
spk resources diagram right above link: https://github.com/CatalystCode/spk/blob/mvDos/documentations/project-service-management-guide.md#requirements

There might be a few others too.

Thanks. I will fix them

@evanlouie
Copy link
Collaborator

docs is the primary standard for most of our repositories as well as most msft repos. We should keep with docs

@dennisseah
Copy link
Collaborator Author

docs is the primary standard for most of our repositories as well as most msft repos. We should keep with docs

docs is used as a folder for serving out web content from git pages. hence we need to move it. git pages does not allow us to change the folder name for web content.

@andrebriggs
Copy link
Collaborator

I propose we have docs for the GitHub Pages stuff and perhaps guides for the markdown documentation we have

@dennisseah
Copy link
Collaborator Author

I propose we have docs for the GitHub Pages stuff and perhaps guides for the markdown documentation we have

I have not problem with this

Copy link
Collaborator

@andrebriggs andrebriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisseah
Copy link
Collaborator Author

@mtarng and @evanlouie, please let me know if this changes are ok with you. And can you please approve it so I can move forward. thanks

@dennisseah
Copy link
Collaborator Author

@andrebriggs am I allowed to merge this one. Tests are failing for different reasons.

@andrebriggs
Copy link
Collaborator

@dennisseah yes, let's merge

@dennisseah dennisseah merged commit 5547e2e into master Feb 19, 2020
@dennisseah dennisseah deleted the mvDos branch February 19, 2020 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants