Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@dennisseah
Copy link
Collaborator

…e is returning status 0

Closes microsoft/bedrock#999

modified code to not catch the exception and return it. Instead allow the exception to propagate to the calling function

@andrebriggs andrebriggs self-requested a review February 17, 2020 07:34
@andrebriggs
Copy link
Collaborator

@dennisseah Tests are failing

@dennisseah
Copy link
Collaborator Author

@dennisseah Tests are failing

Yes, I need help from Nate.

@dennisseah
Copy link
Collaborator Author

@dennisseah Tests are failing

Yes, I need help from Nate.

we have figured out the problem and the problem is in the unit test and our implementation is masking the issue. Hence fixing the implementation causes problem because unit test is incorrect. I have moved the git clone tests to the beginning of the test run and hence ~/.spk/templates/_yradsmikham_spk_source/ is available in the tests later. tests in PR passed now.

Copy link
Collaborator

@NathanielRose NathanielRose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests and unit tests passing locally.

jest.restoreAllMocks();
});

//////////////////////////////////////////////////////////////////////////////
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to keep this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clearly separate git related tests from other tests

@dennisseah dennisseah merged commit 4c9da5a into master Feb 19, 2020
@dennisseah dennisseah deleted the issue999 branch February 19, 2020 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error in generate.ts is masked and hence command line is returning status 0

4 participants