Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Conversation

@dennisseah
Copy link
Collaborator

@dennisseah dennisseah commented Feb 29, 2020

createPullRequest function is too large and it is hard to test https://github.com/CatalystCode/spk/blob/master/src/lib/git/azure.ts#L108

  1. breaks it into small ones
  2. add more tests (boost coverage to 95%)

closes microsoft/bedrock#1078

Copy link
Collaborator

@andrebriggs andrebriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dennisseah dennisseah merged commit d8e38e5 into master Mar 3, 2020
@dennisseah dennisseah deleted the refactorAzureTs branch March 3, 2020 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

break createPullRequest function in lib/git/azure.ts into smaller and testable parts

4 participants