Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

introspection cmds should consume new refactored package #359

Merged
samiyaakhtar merged 5 commits into from
Mar 3, 2020
Merged

introspection cmds should consume new refactored package #359

samiyaakhtar merged 5 commits into from
Mar 3, 2020

Conversation

@samiyaakhtar
Copy link
Collaborator

@samiyaakhtar samiyaakhtar commented Mar 3, 2020

  • consume spk package which uses interfaces instead of classes
  • forward port 5000 of dashboard which the backend server runs on when launched from docker

Closes microsoft/bedrock#1071

@samiyaakhtar samiyaakhtar merged commit b7ab8fc into CatalystCode:master Mar 3, 2020
@samiyaakhtar samiyaakhtar deleted the 1071 branch March 3, 2020 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evanlouie evanlouie Awaiting requested review from evanlouie

@andrebriggs andrebriggs Awaiting requested review from andrebriggs

@mtarng mtarng Awaiting requested review from mtarng

@bnookala bnookala Awaiting requested review from bnookala

@NathanielRose NathanielRose Awaiting requested review from NathanielRose

4 more reviewers

@edaena edaena edaena approved these changes

@sarath-p sarath-p sarath-p approved these changes

@dennisseah dennisseah dennisseah approved these changes

@yradsmikham yradsmikham yradsmikham approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spk should use new updated spektate package that introduces separation between backend and frontend

5 participants

@samiyaakhtar @edaena @sarath-p @dennisseah @yradsmikham