Hide Menu Bar, Bump NPM Packaging #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JaydenDev Take a look at this. |
Collaborator
|
so what exactly is bump npm packaging. |
Contributor
Author
|
I don't know, it said that the package-lock.json was made with an old version and it resolved that. |
Contributor
Author
|
I could .gitignore that and remake the pull if you would like. |
Collaborator
|
oh its all good, merging btw I got font awesome icons working and replacd the text on the buttons to the font awesome icons |
Collaborator
|
i forgot to git push my commits before merging, reverting. |
Contributor
Author
|
Do I need to pull from upstream? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all.
Tested it, and it seems to work.
If you have any questions, just let me know :)