Skip to content

Conversation

@webdev03
Copy link
Contributor

@webdev03 webdev03 commented Dec 20, 2021

Resolves #23
Screen Shot 2021-12-20 at 11 10 52 PM
This is a work in progress and I am going to sleep soon, tomorrow morning I will work on this more.

@webdev03
Copy link
Contributor Author

I made it so you can remove tabs now, please check this tonight but don't merge, I need to make the UI better as I am a bit sleepy.

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 20, 2021

(also what is the colour scheme for Catalyst so I can make the equivalent with Tailwind colour palette? I can't seem to find the logo now)

@webdev03 webdev03 mentioned this pull request Dec 20, 2021
Closed
@webdev03
Copy link
Contributor Author

By the way, I needed a page to load on start, so I made a really barebones Welcome page.

@webdev03
Copy link
Contributor Author

I'm going to go now, in the future, make sure that nobody changes the ID names without carefully updating the JS and testing it as the tabs rely on these ID names.

@webdev03
Copy link
Contributor Author

Screen Shot 2021-12-20 at 11 10 52 PM

Favicons will be implemented tomorrow.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

Oh heck yes this is getting good.
That UI is nice!

@webdev03
Copy link
Contributor Author

Thank you so much!

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

Thank you so much!

Once tabs are finished, should I release 1.0 or wait til the originally planned release date of January 1st, 2022.

@PurpleZen
Copy link

Thank you so much!

Once tabs are finished, should I release 1.0 or wait til the originally planned release date of January 1st, 2022.

You could always release it as a pre-release/beta, allowing users to try things out and report any bugs/issues before it officially releases on the 1st.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

@LegoManiac04 The 1st seems a bit far away, I kinda want people to see this kool browser.
Ninetails is a compeititor and they are far ahead

@jdev082 jdev082 marked this pull request as ready for review December 20, 2021 19:57
@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

ready to merge?

@jdev082 jdev082 merged commit 9f87e25 into CatalystDevOrg:master Dec 20, 2021
@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

@webdev03 you did say it was ready right?

@webdev03
Copy link
Contributor Author

No it was a draft

@webdev03
Copy link
Contributor Author

Please revert it and let me make the req again

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

Please revert it and let me make the req again

ok, and btw. you brought an old ninetails bug into the browser. Can't log into the scratch website, look at the ninetails repo to fix the bug

@webdev03
Copy link
Contributor Author

Nevermind I'll work on it in another PR I gtg

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

@webdev03 make sure to fix the scratch bug!

@webdev03
Copy link
Contributor Author

Which bug?

@webdev03
Copy link
Contributor Author

Ah, oh well, how did you fix that bug?

@MystPi
Copy link

MystPi commented Dec 20, 2021

It's a little too similar to Ninetails IMO. Could you change it up a bit?

@webdev03
Copy link
Contributor Author

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs

4 participants