Skip to content

Conversation

@webdev03
Copy link
Contributor

@webdev03 webdev03 commented Dec 20, 2021

Resolves #30
Resolves #31

@webdev03 webdev03 marked this pull request as draft December 20, 2021 20:36
@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

let me know when its finished

@webdev03
Copy link
Contributor Author

K! What else to add?

@webdev03
Copy link
Contributor Author

And also, where is Catalyst logo VelocityDesign made?

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

I'm having trouble finding it
@VelocityDesign
Where's the logo, I lost it.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

@webdev03 you can also implement search in search bar in this PR. make sure to add BOTH https and http support

@webdev03
Copy link
Contributor Author

Okay, I will implement that...

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 20, 2021

Can I change the search bar logic in a new file? It will help me focus.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

Sure you can split files @webdev03

@webdev03
Copy link
Contributor Author

Thanks!

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

the more files, the more promising a browser looks than it actually is.
yes

@webdev03
Copy link
Contributor Author

LOL

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

Can you also hide all the scroll bars int he webview, it makes it look cleaner.

@webdev03
Copy link
Contributor Author

Why?

@webdev03
Copy link
Contributor Author

Some pages have scrolling, do you mean overflow: auto;?

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

idk

@webdev03
Copy link
Contributor Author

I'm working on autocompletion! :D

@webdev03
Copy link
Contributor Author

It's going well, just need to get the UI set and working, and we're done! 🎉

@webdev03
Copy link
Contributor Author

I also am going to add inbuilt "popup blocking" 🤣

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

I also am going to add inbuilt "popup blocking" 🤣

that will break lots of websites, dont.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

auto completion, cool thats very conveniant
fresh UI, good

popup blocking, breaks lots of websites

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 20, 2021

Oh, okay, I'll remove that. It said it was a security risk, like if you go to a bad website, they can run random code on the browser.
And random code, I think NODEJS, so you could rm rf

@webdev03
Copy link
Contributor Author

Screen Shot 2021-12-21 at 10 20 55 AM

I'm going to make the autocomplete go in front of the webview but not pull it down.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

some changes to how the suggestions look and a changing of the tab background are some changes that gotta happen.

@webdev03
Copy link
Contributor Author

OK, can you tell me which changes?

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

OK, can you tell me which changes?

they just needa to be modernized with some tailwind

@webdev03
Copy link
Contributor Author

I am doing that. I am trying to make it round right now. Just wait.

@webdev03
Copy link
Contributor Author

Can you try to load roblox.com in the current version of Catalyst? Doesn't work for me.

@webdev03
Copy link
Contributor Author

GTG

@jdev082
Copy link
Collaborator

jdev082 commented Dec 20, 2021

should i merge..??

@kccuber-scratch

This comment has been minimized.

@webdev03
Copy link
Contributor Author

Don't merge yet.

@webdev03
Copy link
Contributor Author

Now working on Favicons.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 21, 2021

ok

@webdev03
Copy link
Contributor Author

Favicons! Favicons!
Screen Shot 2021-12-21 at 1 47 23 PM

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 21, 2021

By the way, I rearranged the back and forward buttons, as the earlier position didn't make sense to me.
The styling of the favicons was done by me. I again viewed the Ninetails code to see how they implemented Favicons.

Have any of you found real documentation for webviews?

@webdev03 webdev03 marked this pull request as ready for review December 21, 2021 00:53
@jdev082
Copy link
Collaborator

jdev082 commented Dec 21, 2021

completely finished?

@jdev082
Copy link
Collaborator

jdev082 commented Dec 21, 2021

well im merging so i hope it is...

@jdev082 jdev082 merged commit 452361b into CatalystDevOrg:master Dec 21, 2021
@webdev03
Copy link
Contributor Author

Yes.

@webdev03 webdev03 deleted the better-tabs branch December 26, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Searching in the search bar. Tabs, part two.

3 participants