-
Notifications
You must be signed in to change notification settings - Fork 26
add auto building #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You won't make the release yourself, you just make the git tag from the cli/github desktop and push it. Then Electron Forge can handle all the rest, creating the release with binaries. Then you can edit the description and release it 😄 |
|
Thanks! |
|
Can you try it? @JaydenDev I'd love to see it in action, can you make a tag for it, you can even make a tag online I think |
|
@webdev03 |
|
You can. |
|
Just run |
|
You have to create tags via github |
|
and it does not let you |
|
You can use https://user-images.githubusercontent.com/75148774/147155381-9476f789-b01e-47c8-8c1a-534733c9b46b.png |
|
npm ERR! Git working directory not clean. npm ERR! A complete log of this run can be found in: |
|
so yeah no you cant |
|
No, you need to commit your changes :P |
|
❯ npm version minor |
|
No, that versions your package.json |
|
"npm version" shows the version of npm |
|
Look, can I give you some steps |
|
"npm version" shows the version of NPM |
|
|
|
https://github.com/webdev03/ninetails/tree/v2.3.0 this tag was made with the CLI. |
|
Hmm, that's weird |
|
i got it to work but ur GH action is a failure. |
|
I made a fix for it. For some reason, while I was typing, my editor broke it. So sorry!! 😭 |
This is a bit different from the ninetails system.

What you first do, is create a tag that starts with v, like this from https://dev.to/erikhofer/build-and-publish-a-multi-platform-electron-app-on-github-3lnd where I got this system from:
Then, a draft PR should come up in your releases. Edit the description and stuff, then release it!