Skip to content

Conversation

@webdev03
Copy link
Contributor

This is a bit different from the ninetails system.
What you first do, is create a tag that starts with v, like this from https://dev.to/erikhofer/build-and-publish-a-multi-platform-electron-app-on-github-3lnd where I got this system from:
image
Then, a draft PR should come up in your releases. Edit the description and stuff, then release it!

@webdev03
Copy link
Contributor Author

You won't make the release yourself, you just make the git tag from the cli/github desktop and push it. Then Electron Forge can handle all the rest, creating the release with binaries. Then you can edit the description and release it 😄

@jdev082 jdev082 merged commit 8753925 into CatalystDevOrg:master Dec 22, 2021
@webdev03
Copy link
Contributor Author

Thanks!

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 22, 2021

Can you try it? @JaydenDev I'd love to see it in action, can you make a tag for it, you can even make a tag online I think

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

@webdev03
you cant make a tag without makin a release

@webdev03
Copy link
Contributor Author

You can.

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 22, 2021

Just run npm version minor or whatever npm version it automatically adds a tag too. Then
git push --follow-tags

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

You have to create tags via github

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

and it does not let you

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 22, 2021

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

npm ERR! Git working directory not clean.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/jmwills/.npm/_logs/2021-12-22T21_38_36_194Z-debug.log

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

so yeah no you cant

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 22, 2021

No, you need to commit your changes :P
Have you done that? You need to have a clean, no changes, exactly as the remote, for a tag to be made.

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

❯ npm version minor
v21.13.0

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 22, 2021

No, that versions your package.json

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

"npm version" shows the version of npm
are you stupid?

@webdev03
Copy link
Contributor Author

Look, can I give you some steps

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

"npm version" shows the version of NPM

@webdev03
Copy link
Contributor Author

webdev03 commented Dec 22, 2021

npm version 0.4.0 will work. Trust me. https://docs.npmjs.com/cli/v6/commands/npm-version

@webdev03
Copy link
Contributor Author

https://github.com/webdev03/ninetails/tree/v2.3.0 this tag was made with the CLI.

@webdev03
Copy link
Contributor Author

Hmm, that's weird

@jdev082
Copy link
Collaborator

jdev082 commented Dec 22, 2021

i got it to work but ur GH action is a failure.
dont upload broken PRs.

@webdev03
Copy link
Contributor Author

I made a fix for it. For some reason, while I was typing, my editor broke it. So sorry!! 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants