Skip to content

feat: preserve entity selection across viewer/editor modes#104

Open
JohnRDOrazio wants to merge 1 commit intodevfrom
feat/preserve-entity-selection
Open

feat: preserve entity selection across viewer/editor modes#104
JohnRDOrazio wants to merge 1 commit intodevfrom
feat/preserve-entity-selection

Conversation

@JohnRDOrazio
Copy link
Copy Markdown
Member

Summary

  • Pass classIri query param when navigating from viewer to editor via "Open Editor" button
  • Add "Close Editor" button (Eye icon) in editor that returns to viewer with selection preserved
  • Remove ContinuousEditingToggle component — being in the editor now implies edit mode
  • Remove continuousEditing preference from editorModeStore and user settings
  • Simplify ClassDetailPanel, PropertyDetailPanel, IndividualDetailPanel: auto-enter edit mode when onUpdate* handler is provided (editor context)

Closes #98

Test plan

  • Select an entity in the viewer, click "Open Editor" — editor opens with same entity selected
  • In the editor, click "Close Editor" — returns to viewer with same entity selected
  • Detail panels in the editor auto-enter edit mode without requiring extra "Edit" click
  • User can cancel edit mode on a specific entity and it stays in read-only for that entity
  • Viewer pages remain read-only (no edit mode)
  • No regression in suggestion mode behavior

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Warning

Rate limit exceeded

@JohnRDOrazio has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 29 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 29 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f210f2c1-092c-4f04-b5bd-71fa30c44961

📥 Commits

Reviewing files that changed from the base of the PR and between df31e07 and c6e8bdf.

📒 Files selected for processing (13)
  • __tests__/components/editor/ClassDetailPanel.test.tsx
  • __tests__/components/editor/ContinuousEditingToggle.test.tsx
  • __tests__/components/editor/IndividualDetailPanel.test.tsx
  • __tests__/components/editor/PropertyDetailPanel.test.tsx
  • __tests__/lib/stores/editorModeStore.test.ts
  • app/projects/[id]/editor/page.tsx
  • app/projects/[id]/page.tsx
  • app/settings/page.tsx
  • components/editor/ClassDetailPanel.tsx
  • components/editor/ContinuousEditingToggle.tsx
  • components/editor/IndividualDetailPanel.tsx
  • components/editor/PropertyDetailPanel.tsx
  • lib/stores/editorModeStore.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/preserve-entity-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
components/editor/ClassDetailPanel.tsx 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@JohnRDOrazio JohnRDOrazio force-pushed the feat/preserve-entity-selection branch from 4860ceb to 0b3edc5 Compare April 10, 2026 23:38
Pass classIri query param when navigating between viewer and editor.
Replace "Back" link with "Close Editor" button that preserves selection.
Remove ContinuousEditingToggle — being in the editor now implies edit
mode for the selected entity. Simplify ClassDetailPanel, PropertyDetailPanel,
and IndividualDetailPanel edit state by auto-entering edit mode when
onUpdate handler is provided (editor context).

Closes #98

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@JohnRDOrazio JohnRDOrazio force-pushed the feat/preserve-entity-selection branch from 0b3edc5 to c6e8bdf Compare April 11, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve entity selection across viewer/editor and unify continuous editing

1 participant