Open a card from the lockscreen widget without unlock#3091
Open
hipgnose wants to merge 4 commits intoCatimaLoyalty:mainfrom
Open
Open a card from the lockscreen widget without unlock#3091hipgnose wants to merge 4 commits intoCatimaLoyalty:mainfrom
hipgnose wants to merge 4 commits intoCatimaLoyalty:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To open the activity over the lockscreen we can't use the
setShowWhenLocked(true), we need to define the activity manifest asshowWhenLocked=true, as stated in the Android Developers FAQ.This PR adds the manifest configuration needed to open the activity and disable/hide the activity if the user chose
DisableLockscreenWhileViewingCardsettingIn the first commit I was finishing the activity if
DisableLockscreenWhileViewingCardwas off and the lockscreen was up, but I figured out that we can just callshowWhenLocked(false)and the activity is sent to behind the lockscreen again.Notes:
startWithLoyaltyCardNoExpirySetExpiryis failing for me, it says it expected April 22 but receives April 21, I don't know why but maybe it 's something with my timezone?Fixes #2916