Skip to content

SHARE-459 License to play one column on mobile#1467

Merged
dmetzner merged 1 commit intoCatrobat:developfrom
maxfazeli-dev:SHARE-459
Apr 12, 2021
Merged

SHARE-459 License to play one column on mobile#1467
dmetzner merged 1 commit intoCatrobat:developfrom
maxfazeli-dev:SHARE-459

Conversation

@maxfazeli-dev
Copy link
Contributor

@maxfazeli-dev maxfazeli-dev commented Apr 12, 2021

"License to play" page is now shown in single column layout on small screens and mobiles.


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

"License to play" page should is now shown in single column layout on small screens and mobiles.
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1467 (9ac0eea) into develop (bb76e73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1467   +/-   ##
==========================================
  Coverage      45.86%   45.86%           
  Complexity      4690     4690           
==========================================
  Files            625      625           
  Lines          16268    16268           
==========================================
  Hits            7461     7461           
  Misses          8807     8807           
Flag Coverage Δ Complexity Δ
behat 42.86% <ø> (ø) 0.00 <ø> (ø)
phpunit 10.01% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e25820...9ac0eea. Read the comment docs.

@maxfazeli-dev maxfazeli-dev marked this pull request as ready for review April 12, 2021 14:56
@dmetzner dmetzner self-requested a review April 12, 2021 18:12
@dmetzner dmetzner merged commit f286dd2 into Catrobat:develop Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants