Skip to content

Reduce static analysis baselines#6319

Merged
dmetzner merged 2 commits intodevelopfrom
fix/reduce-static-analysis-baselines
Mar 26, 2026
Merged

Reduce static analysis baselines#6319
dmetzner merged 2 commits intodevelopfrom
fix/reduce-static-analysis-baselines

Conversation

@dmetzner
Copy link
Collaborator

Summary

  • remove the PHPStan baseline and keep PHPStan green without it
  • reduce the remaining static-analysis noise with targeted type and null-safety fixes across controllers, entities, commands, and tests
  • keep Psalm baseline-backed for now because a no-baseline run still reports hundreds of issues

Verification

  • bin/phpstan analyze --no-progress --debug
  • bin/psalm --config=.psalm-no-baseline.xml --no-progress --threads=1 --scan-threads=1 --no-cache (investigation only: still reports 510 errors without a baseline)

@codecov
Copy link

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 43.45404% with 203 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.03%. Comparing base (9188359) to head (d0125cb).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/System/Testing/Behat/ContextTrait.php 53.96% 29 Missing ⚠️
.../Projects/ApproveProjects/ApproveProjectsAdmin.php 0.00% 17 Missing ⚠️
src/System/Commands/MigrateRemixGraphsCommand.php 0.00% 16 Missing ⚠️
src/System/Commands/Reset/ResetCommand.php 0.00% 16 Missing ⚠️
.../Projects/SpecialProjects/FeaturedProjectAdmin.php 0.00% 13 Missing ⚠️
src/Admin/Projects/ProjectPreUpdateTrait.php 0.00% 11 Missing ⚠️
...n/Projects/SpecialProjects/ExampleProjectAdmin.php 0.00% 10 Missing ⚠️
src/Admin/ApkGeneration/ApkController.php 0.00% 8 Missing ⚠️
src/Api/CommentsApi.php 68.00% 8 Missing ⚠️
src/Api/ProjectsApi.php 50.00% 8 Missing ⚠️
... and 24 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6319      +/-   ##
=============================================
- Coverage      56.20%   56.03%   -0.17%     
- Complexity      9171     9179       +8     
=============================================
  Files            784      784              
  Lines          29093    29256     +163     
=============================================
+ Hits           16351    16394      +43     
- Misses         12742    12862     +120     
Flag Coverage Δ
behat 53.79% <42.89%> (-0.16%) ⬇️
phpunit 10.89% <8.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmetzner dmetzner merged commit e95e62c into develop Mar 26, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant