Skip to content

SHARE-397 Prevent chrome exceptions#913

Merged
dmetzner merged 1 commit intoCatrobat:developfrom
dmetzner:SHARE-397
Sep 20, 2020
Merged

SHARE-397 Prevent chrome exceptions#913
dmetzner merged 1 commit intoCatrobat:developfrom
dmetzner:SHARE-397

Conversation

@dmetzner
Copy link
Copy Markdown
Collaborator

@dmetzner dmetzner commented Sep 17, 2020

  • refactored notification UI tests
  • adapted chrome docker headless start command for docker
  • adapted GitHub actions to re-run chrome exceptions once

@dmetzner dmetzner changed the title Share 397 SHARE-397 Prevent chrome excpetions Sep 17, 2020
@dmetzner dmetzner changed the title SHARE-397 Prevent chrome excpetions SHARE-397 Prevent chrome exceptions Sep 17, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2020

Codecov Report

Merging #913 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #913   +/-   ##
==========================================
  Coverage      43.43%   43.43%           
- Complexity      4308     4310    +2     
==========================================
  Files            569      569           
  Lines          15116    15118    +2     
==========================================
+ Hits            6565     6567    +2     
  Misses          8551     8551           
Flag Coverage Δ Complexity Δ
#behat 41.80% <100.00%> (+<0.01%) 4310.00 <0.00> (+2.00)
#phpunit 7.71% <0.00%> (-0.01%) 4310.00 <0.00> (+2.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Catrobat/Services/TestEnv/SymfonySupport.php 81.89% <100.00%> (+0.10%) 98.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff210d...ee8ba9d. Read the comment docs.

- refactored notification UI tests
- adapted chrome docker headless start command for docker
- adapted GitHub actions to re-run chrome exceptions once
@dmetzner dmetzner marked this pull request as ready for review September 20, 2020 07:03
@dmetzner dmetzner requested a review from HCrane September 20, 2020 07:03
@dmetzner dmetzner merged commit f96b11c into Catrobat:develop Sep 20, 2020
@dmetzner dmetzner deleted the SHARE-397 branch September 21, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants