Skip to content

PAINTROID-567 Fixed ColorDialogIntegrationTest#1230

Closed
Smarshal21 wants to merge 1 commit intoCatrobat:developfrom
Smarshal21:ColorDialogIntegrationTest
Closed

PAINTROID-567 Fixed ColorDialogIntegrationTest#1230
Smarshal21 wants to merge 1 commit intoCatrobat:developfrom
Smarshal21:ColorDialogIntegrationTest

Conversation

@Smarshal21
Copy link
Contributor

Jira Ticket - https://jira.catrob.at/browse/PAINTROID-567
Fixed ColorDialogIntegrationTest
Fixed 2 tests failing on ColorDialogIntegrationTest

  1. testColorPickerTabRestoredOnOrientationChange
  2. testifRGBSeekBarsDoChangeColor

Screenshot 2023-03-18 at 12 33 54 AM

Screenshot 2023-03-18 at 12 34 22 AM

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@Smarshal21
Copy link
Contributor Author

@exland @ThorstenBandel @Lenkomotive @StefanKutschera could you please review this Fix

@exland
Copy link
Contributor

exland commented Mar 18, 2023

Did u take a look at jenkins? 140 tests fail

@Smarshal21
Copy link
Contributor Author

Did u take a look at jenkins? 140 tests fail

but the tests run fine locally, how should i move forward now ? come up with a different solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants