Skip to content

PAINTROID-574 Refactored test and functionality from java to kotlin#1240

Open
Smarshal21 wants to merge 8 commits intoCatrobat:developfrom
Smarshal21:Refactoring3
Open

PAINTROID-574 Refactored test and functionality from java to kotlin#1240
Smarshal21 wants to merge 8 commits intoCatrobat:developfrom
Smarshal21:Refactoring3

Conversation

@Smarshal21
Copy link
Contributor

jira ticket - https://jira.catrob.at/browse/PAINTROID-574
Successfully refactored the following files from java to Kotlin

FillToolIntegrationTest
FlipToolIntegrationTest
CustomViewInteraction
DrawingSurfaceInteraction

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@exland
Copy link
Contributor

exland commented Mar 25, 2023

Hi,

  1. could you please fix the static warnings in Jenkins?
  2. these tickets are not ready for development, yet :)

Copy link
Contributor

@exland exland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the static warnings in the jenkins

@Smarshal21
Copy link
Contributor Author

Fix the static warnings in the jenkins

Done

exland
exland previously approved these changes Mar 25, 2023
@exland exland dismissed their stale review March 25, 2023 18:54

wanted to remove the change

@Smarshal21
Copy link
Contributor Author

which change?

@Smarshal21
Copy link
Contributor Author

@exland fixed static warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants