Skip to content

fix: copy dashboard package manifests from builder#160

Merged
nullure merged 2 commits intoCaviraOSS:mainfrom
haosenwang1018:fix/dashboard-docker-package-manifest
Apr 10, 2026
Merged

fix: copy dashboard package manifests from builder#160
nullure merged 2 commits intoCaviraOSS:mainfrom
haosenwang1018:fix/dashboard-docker-package-manifest

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Summary

  • stop the dashboard production image from depending on package*.json being present in the final build context
  • copy package.json and package-lock.json from the builder stage before running npm install --omit=dev

Why

Issue #134 reports docker compose up failing in the dashboard production stage with:

ENOENT: no such file or directory, open '/app/package.json'

The failure happens in the production stage at:

COPY package*.json ./
RUN npm install --omit=dev

Copying the package manifests from the already-populated builder stage makes the production stage self-consistent and avoids relying on the external build context for those files a second time.

Testing

  • inspected the failing dashboard Docker stage from issue [BUG] docker compose up not working #134
  • verified the patch keeps the production install step supplied with explicit package manifests from the builder stage

Closes #134

Copy link
Copy Markdown
Member

@nullure nullure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullure nullure merged commit 7aba929 into CaviraOSS:main Apr 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] docker compose up not working

2 participants