Skip to content

fix: accept top-level temporal query filters#163

Merged
nullure merged 3 commits intoCaviraOSS:mainfrom
haosenwang1018:fix/accept-top-level-temporal-query-filters
Apr 11, 2026
Merged

fix: accept top-level temporal query filters#163
nullure merged 3 commits intoCaviraOSS:mainfrom
haosenwang1018:fix/accept-top-level-temporal-query-filters

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Summary

  • make /memory/query accept top-level startTime and endTime request fields in addition to the nested filters form
  • update the shared q_req type so the route implementation and request shape stay in sync

Why

Issue #105 reports that temporal filtering is ignored for /query-style requests like:

{"query":"text","startTime":9999999999999}

The root cause is that /memory/query only read:

  • filters.startTime
  • filters.endTime

So top-level temporal fields were silently ignored, even though another query entrypoint (/query in routes/vercel.ts) already accepts the top-level form.

This patch makes the main /memory/query route honor the same top-level temporal filters, which matches the reported reproduction and keeps both query entrypoints consistent.

Testing

  • cd packages/openmemory-js && npm run build

Closes #105

Copy link
Copy Markdown
Member

@nullure nullure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nullure nullure merged commit 4409b40 into CaviraOSS:main Apr 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Temporal filtering parameters (startTime/endTime) not exposed in /query endpoint

2 participants