fix: accept top-level temporal query filters#163
Merged
nullure merged 3 commits intoCaviraOSS:mainfrom Apr 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/memory/queryaccept top-levelstartTimeandendTimerequest fields in addition to the nestedfiltersformq_reqtype so the route implementation and request shape stay in syncWhy
Issue #105 reports that temporal filtering is ignored for
/query-style requests like:{"query":"text","startTime":9999999999999}The root cause is that
/memory/queryonly read:filters.startTimefilters.endTimeSo top-level temporal fields were silently ignored, even though another query entrypoint (
/queryinroutes/vercel.ts) already accepts the top-level form.This patch makes the main
/memory/queryroute honor the same top-level temporal filters, which matches the reported reproduction and keeps both query entrypoints consistent.Testing
cd packages/openmemory-js && npm run buildCloses #105