Skip to content

RA modification patches to transpilers#30

Closed
Axwabo wants to merge 2 commits into
CedModV2:masterfrom
Axwabo:ra-mods-to-transpilers
Closed

RA modification patches to transpilers#30
Axwabo wants to merge 2 commits into
CedModV2:masterfrom
Axwabo:ra-mods-to-transpilers

Conversation

@Axwabo
Copy link
Copy Markdown

@Axwabo Axwabo commented Mar 12, 2023

Harmony prefixes are an easy way to modify a method but may prevent others from further modifying it.

Converted the following patches to transpilers:

  • RaPlayerListPatch
  • RaPlayerPatch
  • RaPlayerAuthPatch

This enables other developers to patch the methods.

@moddedmcplayer
Copy link
Copy Markdown
Member

just so you know you're gonna be the one maintaining them or they'll just become prefixes again next time this changes lmao xd

@ced777ric
Copy link
Copy Markdown
Member

And this has all been tested?

@Axwabo
Copy link
Copy Markdown
Author

Axwabo commented Mar 13, 2023

Can confirm that all modified features work:

image
image

Copy link
Copy Markdown
Member

@ced777ric ced777ric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts, idk how the transpilers do their thing so im not gonna touch it for now

@Misaka-ZeroTwo
Copy link
Copy Markdown

just so you know you're gonna be the one maintaining them or they'll just become prefixes again next time this changes lmao xd

get good and learn how it works XD

@moddedmcplayer
Copy link
Copy Markdown
Member

just so you know you're gonna be the one maintaining them or they'll just become prefixes again next time this changes lmao xd

get good and learn how it works XD

no

@ced777ric ced777ric closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants