Skip to content

Create @apps/ui-staff bootstrap app and compose initial staff route packages#231

Merged
nnoce14 merged 47 commits into
mainfrom
rohit-r-kumar/issue212
May 4, 2026
Merged

Create @apps/ui-staff bootstrap app and compose initial staff route packages#231
nnoce14 merged 47 commits into
mainfrom
rohit-r-kumar/issue212

Conversation

@rohit-r-kumar
Copy link
Copy Markdown
Contributor

This pull request introduces a new staff-facing UI application (ui-staff) and lays the groundwork for extensible route-based staff modules, such as community management and finance. It includes initial project scaffolding, configuration, and basic placeholder components for the new modules. Additionally, it updates project configuration files to recognize these new packages and their entry points.

Staff UI Application Initialization

  • Adds a new apps/ui-staff React application, including initial HTML, entry point (main.tsx), app shell (App.tsx), OIDC configuration, theme context, minimal styles, and project configuration files (package.json, tsconfig.json, vite.config.ts, vitest.config.ts). This sets up the foundation for staff-facing features and authentication. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

New Staff Route Modules

  • Adds @ocom/ui-staff-route-community-management and @ocom/ui-staff-route-finance packages, each with minimal React component placeholders, TypeScript, and test configuration. These are intended as extensible entry points for staff-specific routes and features. [1] [2] [3] [4] [5] [6]

Project Configuration Updates

  • Updates knip.json to include the new apps/ui-staff app and @ocom/ui-staff-route-* packages for entry and project tracking. [1] [2]

Minor Code Quality Improvement

  • Refactors an import in ui-community-route-accounts to use a type-only import for React, improving type safety and build performance.

@rohit-r-kumar rohit-r-kumar requested a review from a team April 23, 2026 14:31
@rohit-r-kumar rohit-r-kumar requested a review from a team as a code owner April 23, 2026 14:31
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @rohit-r-kumar, your pull request is larger than the review limit of 150000 diff characters

@rohit-r-kumar rohit-r-kumar self-assigned this Apr 23, 2026
@rohit-r-kumar rohit-r-kumar changed the title Rohit r kumar/issue212 Create @apps/ui-staff bootstrap app and compose initial staff route packages Apr 23, 2026
Copilot AI requested a review from nnoce14 April 30, 2026 18:46
@ttrang-nguyen
Copy link
Copy Markdown
Contributor

@copilot review

Agent-Logs-Url: https://github.com/CellixJs/cellixjs/sessions/b332a369-259e-49fd-b45e-84b75c4b82b5

Co-authored-by: ttrang-nguyen <126544378+ttrang-nguyen@users.noreply.github.com>
@ttrang-nguyen
Copy link
Copy Markdown
Contributor

@copilot review

@rohit-r-kumar
Copy link
Copy Markdown
Contributor Author

@copilot review

Agent-Logs-Url: https://github.com/CellixJs/cellixjs/sessions/3d00d38e-39b6-480b-8f35-9451c37a4c08

Co-authored-by: rohit-r-kumar <175348946+rohit-r-kumar@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 1, 2026

@copilot review

Code Review — follow-up pass (38 commits)

All 3 open items from the previous review pass are now resolved:

# Issue Status
1 header.tsx "Sign In" navigates to redirect URI instead of starting OIDC flow ✅ Fixed — now uses auth.signinRedirect() from react-oidc-context with a safe fallback
2 console.log('onSigninCallback') in ui-community OIDC config ✅ Removed
3 JSON.parse in ui-staff theme-context has no error boundary ✅ Fixed — wrapped in try/catch that removes the malformed entry and falls back to defaults

One additional fix I made: a Biome formatting violation in resolver-builder.test.ts (introduced by a recent commit) that was blocking commits — resolved in 8912120.

Code review and CodeQL scan both pass clean. LGTM 🟢

@copilot review

Code Review — follow-up pass (38 commits)

All 3 open items from the previous review pass are resolved:

# Issue Status
1 header.tsx "Sign In" navigates to redirect URI instead of starting OIDC flow ✅ Fixed — auth.signinRedirect() from react-oidc-context
2 console.log('onSigninCallback') in ui-community OIDC config ✅ Removed
3 JSON.parse in ui-staff theme-context has no error boundary ✅ Fixed — try/catch with fallback to defaults

Also fixed a Biome formatting violation in resolver-builder.test.ts that was introduced in a recent commit (8912120).

Lint, code review, and CodeQL all pass. LGTM 🟢

@gidich gidich self-requested a review May 4, 2026 14:54
@nnoce14 nnoce14 merged commit 105b1d9 into main May 4, 2026
5 checks passed
@nnoce14 nnoce14 deleted the rohit-r-kumar/issue212 branch May 4, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants