[NEW DEVICES AND MLP] H100 and batch_norm mlp #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johncalesp
commented
Jun 27, 2024
johncalesp
commented
- Added new MLP for batch_norm
- Added H100 data
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| elif operation.name == 'conv_transpose2d': | ||
| return self._special_scale(operation, dest_device, self._conv_transpose2d_scale, unscaled) | ||
| elif operation.name == "batch_norm": | ||
| return self._special_scale(operation, dest_device, self._batch_norm_scale, unscaled) |
There was a problem hiding this comment.
Avoid too many return statements within this function.
|
|
||
| measurer.measure_configurations(args, num_configs) | ||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Identical blocks of code found in 6 locations. Consider refactoring.
jimgao1
suggested changes
Jun 27, 2024
Contributor
jimgao1
left a comment
jimgao1
left a comment
There was a problem hiding this comment.
Just some minor things but generally looks very good
tools/recording/record_common.py
Outdated
| config[len(config) - len(sample) :] = sample | ||
| # for bachnorm, config is (batch, channel, image_size) and we need to replace channel := pos[1] | ||
| if self._op_name == "batch_norm": | ||
| config[1] = sample[0] |
Contributor
There was a problem hiding this comment.
Why is this logic implemented here but not record_batchnorm.py? It seems like we just need to modify the index_to_config function to avoid adding a special case here.
Contributor
Author
There was a problem hiding this comment.
sry, I changed the order, now it should be ok
|
Code Climate has analyzed commit 3cb49e8 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jimgao1
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.