Skip to content

Remove compilation#130

Merged
michaelshin merged 2 commits intomainfrom
mshin/remove-compilation
Apr 9, 2026
Merged

Remove compilation#130
michaelshin merged 2 commits intomainfrom
mshin/remove-compilation

Conversation

@michaelshin
Copy link
Copy Markdown
Contributor

@michaelshin michaelshin commented Apr 1, 2026

Removed the compilation feature from the client as that is deprecated.

Summary by CodeRabbit

  • Removals
    • Removed remote compilation server and submission endpoints
    • Removed prediction backend with profiling and metrics collection
    • Removed compile() function from package public API
    • Removed Hidet dependencies and backend compilation support
    • Removed server CLI command
    • Removed related test files and example scripts

@michaelshin michaelshin requested a review from anandj91 April 1, 2026 18:20
@michaelshin michaelshin self-assigned this Apr 1, 2026
@anandj91
Copy link
Copy Markdown
Contributor

anandj91 commented Apr 6, 2026

@anandj91
Copy link
Copy Markdown
Contributor

anandj91 commented Apr 6, 2026

tests/sample_data.csv this one too

@michaelshin michaelshin force-pushed the mshin/remove-compilation branch from c71d184 to 13c5b05 Compare April 7, 2026 15:52
@anandj91
Copy link
Copy Markdown
Contributor

anandj91 commented Apr 9, 2026

@CodeRabbit full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ff1c8627-564e-40f9-9e8b-bd13041b3a1a

📥 Commits

Reviewing files that changed from the base of the PR and between 5e62d3e and 13c5b05.

⛔ Files ignored due to path filters (1)
  • tests/sample_data.csv is excluded by !**/*.csv
📒 Files selected for processing (24)
  • .github/workflows/unit_tests.yml
  • README.md
  • centml/__init__.py
  • centml/cli/main.py
  • centml/compiler/__init__.py
  • centml/compiler/backend.py
  • centml/compiler/config.py
  • centml/compiler/main.py
  • centml/compiler/prediction/backend.py
  • centml/compiler/prediction/kdtree.py
  • centml/compiler/prediction/metric.py
  • centml/compiler/prediction/profiler.py
  • centml/compiler/server.py
  • centml/compiler/server_compilation.py
  • centml/compiler/utils.py
  • mypy.ini
  • requirements.txt
  • scripts/data_collection.py
  • scripts/prediction_sample.py
  • scripts/pylintrc
  • scripts/timer.py
  • tests/test_backend.py
  • tests/test_helpers.py
  • tests/test_server.py
💤 Files with no reviewable changes (24)
  • .github/workflows/unit_tests.yml
  • mypy.ini
  • centml/init.py
  • centml/compiler/init.py
  • centml/cli/main.py
  • README.md
  • scripts/timer.py
  • scripts/prediction_sample.py
  • centml/compiler/config.py
  • centml/compiler/utils.py
  • centml/compiler/prediction/backend.py
  • tests/test_helpers.py
  • centml/compiler/main.py
  • requirements.txt
  • centml/compiler/prediction/profiler.py
  • tests/test_server.py
  • centml/compiler/server_compilation.py
  • scripts/data_collection.py
  • tests/test_backend.py
  • scripts/pylintrc
  • centml/compiler/prediction/kdtree.py
  • centml/compiler/prediction/metric.py
  • centml/compiler/server.py
  • centml/compiler/backend.py

Walkthrough

This pull request removes remote compilation infrastructure and the Hidet backend integration from the codebase. Deleted features include the FastAPI server for remote model compilation, the compilation backend and related configuration system, prediction/profiling utilities, CLI server commands, sample scripts, and associated test coverage. Dependencies for FastAPI, Uvicorn, Prometheus, SciPy, and scikit-learn have also been removed.

Changes

Cohort / File(s) Summary
Workflow & Package Configuration
.github/workflows/unit_tests.yml, README.md, mypy.ini, requirements.txt
Removed Hidet-specific documentation (installation prerequisites and entire Compilation section), explicit pip install hidet step from CI, mypy ignore rules for mydet-hidet.*, and six dependencies: fastapi, uvicorn, python-multipart, prometheus-client, scipy, scikit-learn.
Package Exports & CLI
centml/__init__.py, centml/cli/main.py, centml/compiler/__init__.py
Removed compile function from package-level exports and server Click command from CLI; cleaned up compiler package's __all__ list.
Compiler Core
centml/compiler/backend.py, centml/compiler/config.py, centml/compiler/main.py, centml/compiler/server.py, centml/compiler/server_compilation.py, centml/compiler/utils.py
Deleted remote compilation entry point (centml_dynamo_backend), configuration system (Config, enums, settings), compile() function with mode-based control flow, FastAPI server application and endpoints (/status/{model_id}, /submit/{model_id}, /download/{model_id}), Hidet server-side backend wrapper, and filesystem utility helpers.
Prediction System
centml/compiler/prediction/backend.py, centml/compiler/prediction/kdtree.py, centml/compiler/prediction/metric.py, centml/compiler/prediction/profiler.py
Removed entire prediction backend infrastructure including: centml_prediction_backend closure, in-memory KD-tree lookup (TreeDB, KDTreeWithValues, get_tree_db()), Prometheus gauge metrics (GaugeMetric, get_gauge()), and node-level Profiler class for FX graph execution profiling.
Scripts & Utilities
scripts/data_collection.py, scripts/prediction_sample.py, scripts/timer.py, scripts/pylintrc
Removed data collection test suites for LLMs/image classification/object detection, GPU prediction sample, CUDA event timing utility, and pylint configuration for hidet-related checks.
Tests
tests/test_backend.py, tests/test_helpers.py, tests/test_server.py
Deleted comprehensive test coverage for backend remote compilation (caching, hashing, polling), server endpoints (status/submit/download), helper fixtures (MODEL_SUITE), and upload/background compilation logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Simplicity hops into view,
No servers compile, no backends queue,
Predictions fade like morning dew,
Lean and fleet, the codebase anew!
What once was complex, now runs true. 🌿✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove compilation' accurately describes the main change: removing the deprecated compilation feature and all related code, backends, servers, and utilities across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mshin/remove-compilation

Comment @coderabbitai help to get the list of available commands and usage tips.

@michaelshin michaelshin merged commit 19612bb into main Apr 9, 2026
5 checks passed
@michaelshin michaelshin deleted the mshin/remove-compilation branch April 9, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants