Better exception catching #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the call to submit for compilation or to check the model status would fail, then the compilation thread would crash. I added try catch blocks to catch this while still logging the raised errors.
I also added a unit test to cover the case where the call to compilation or status fails.
I also realized that the try catch block around the child thread creation call wasn't actually catching exceptions that happen in the thread, just any exceptions that happen when you create the thread. Since this means that an exception in the child thread won't case the main inference thread to crash, I don't know if we actually need to catch it, but I fixed this to catch exceptions as expected