Conversation
anurlybayev
changed the base branch from
anurlybayev/nvidia-branding-cleanup
to
main
Codex output I switched the site chrome in mint.json to NVIDIA-oriented branding, replaced the old CentML social links with NVIDIA channels, changed the topbar away from CentML contact points, and added simple local NVIDIA CCluster wordmark assets at images/nvidia_ccluster_light.svg and images/nvidia_ccluster_dark.svg. I also removed the pricing and self-service account-creation pages from the published docs by deleting resources/pricing.mdx and resources/account_creation.mdx, and cleaned up all nav/cards that pointed to them. The public-facing docs now avoid the old CentML signup and support-email flow. In particular, home/quickstart.mdx and resources/requesting_support.mdx now say access is provisioned through NVIDIA / your organization instead of telling users to register themselves, and they no longer point people at support@centml.ai or sales@centml.ai. I also updated several supporting pages and “What’s Next” cards to remove pricing references and rename “Agents on CentML” to “Agents on NVIDIA CCluster.” I intentionally left some centml strings in place where they look like real technical identifiers rather than branding, for example: package/import names like centml existing GitHub repo URLs under github.com/CentML/... example hostnames / API identifiers that may still be live infrastructure That keeps us from breaking copy-pasteable commands while still removing the outdated public branding and signup story. Validation-wise, mint.json parses and git diff --check is clean. I did not run a full Mintlify preview, so I haven’t visually verified the rendered site yet.
anurlybayev
force-pushed
the
anurlybayev/legal-footer-disclosures
branch
from
f4188c4 to
2d3bf38
Compare
|
@V2arK rebased and updated. Ready for review. |
V2arK
left a comment
V2arK
left a comment
There was a problem hiding this comment.
I can pick it up from here and test if you want
| @@ -0,0 +1,76 @@ | |||
| (function () { | |||
There was a problem hiding this comment.
This entire file can be replaced by adding a footer.links array to docs.json. Mintlify natively supports footer text links as a first-class config feature — no custom JavaScript required.
The DOM injection approach (createElement, MutationObserver, requestAnimationFrame) introduces unnecessary complexity for something the framework handles out of the box.
There was a problem hiding this comment.
Actually, you're right. I was able to migrate the minlify from the pinned version to the latest with minimal visual changes in #33. The reason this was done in .js and not footer.links is because we were on the old version. So I think what we should do is close this PR, do the migration to the latest version and then simply implement the footer.links
| } | ||
|
|
||
| const observer = new MutationObserver(scheduleMount); | ||
| observer.observe(document.documentElement, { childList: true, subtree: true }); |
There was a problem hiding this comment.
If for some reason the native footer.links approach is not viable and this JS approach is kept:
This MutationObserver watches the entire document.documentElement subtree and never disconnects. In Mintlify's SPA (Next.js-based), every route change and DOM mutation triggers scheduleMount. Consider disconnecting after successful mount and re-observing only on navigation events.
Also note: Mintlify auto-includes any .js file at the repo root on every page, so this file will load — but it re-runs the full observer setup on every page load in the SPA.
There was a problem hiding this comment.
Hey can you take a look at the #35. It implements the footer.links after the mintlify upgrade.
| line-height: 1.6; | ||
| } | ||
|
|
||
| .nvidia-legal-footer-items a { |
There was a problem hiding this comment.
No dark mode styles. Mintlify has a dark mode toggle — link colors and separator opacity may render poorly.
Another reason to prefer the native footer.links config: Mintlify automatically handles dark/light theming for footer links. With this custom CSS, you'd need to add selectors for [data-theme='dark'] or equivalent.
|
Closing in favor of #35 |
2 participants
Fixes: https://github.com/CentML/platform/issues/3577