Conversation
8ffea9f to
1944b8c
Compare
|
Sample manual build from work so far: |
1944b8c to
c80780b
Compare
c80780b to
07b8c89
Compare
19b0db1 to
33d22fa
Compare
33d22fa to
ed4e5a6
Compare
|
@mohammedzee1000 nice! Have we had a chance to test this container for any behaviour changes compared with the prev one ? we might want to check and document that up a bit. Also, I see you are using specific files in the build, we need to track when this golang goes either into the distro or the PaaS SIG repos and switch to using it from a repo instead of this direct download at the moment. otherwise LGTM, just confirm once re behaviour change and we can merge + move forward. |
|
The primary behaviour change that i have seen so far is I will see if i can do more extensive testing :) Of course, I am not fully aware of all use cases, so if anyone else wants to join in and help test it, they are welcome. I have temporarily pushed a test container to hub with name as mohammedzee1000/caddy-test:latest Of course, i agree with getting the go 1.9 rpms into a repository instead of curling it off cbs and we should get that done asap. But thats is just a couple of lines of from my side change :) @kbsingh ^ |
|
LGTM |
This PR modified the Caddy server to build from source, instead of downloading binaries from caddyserver.com