Skip to content

The settings page is divided into separate sections #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChrisMacNaughton merged 2 commits into from
Dec 7, 2020
Merged

The settings page is divided into separate sections #168

ChrisMacNaughton merged 2 commits into from
Dec 7, 2020

Conversation

@ChrisMacNaughton
Copy link
Member

@ChrisMacNaughton ChrisMacNaughton commented Dec 7, 2020 •
edited
Loading

By having separate sections for the different types of
settings, an administrator has a better experience
with managing EyeDP.

Closes #140

@ChrisMacNaughton ChrisMacNaughton linked an issue Dec 7, 2020 that may be closed by this pull request
EyeDP's admin settings page needs reworking to separate sections onto different pages #140
Closed
@coveralls
Copy link

coveralls commented Dec 7, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 81.869% when pulling 21824f1 on feature/admin-settings-split into 715acac on master.

@ChrisMacNaughton ChrisMacNaughton force-pushed the feature/admin-settings-split branch 2 times, most recently from eeff490 to 293d1e0 Compare December 7, 2020 14:44
@ChrisMacNaughton ChrisMacNaughton force-pushed the feature/admin-improvements branch from 7d7193a to 12bb8e8 Compare December 7, 2020 14:46
@ChrisMacNaughton ChrisMacNaughton force-pushed the feature/admin-settings-split branch from 293d1e0 to 4cd1512 Compare December 7, 2020 14:47
igalic
igalic approved these changes Dec 7, 2020
View reviewed changes
Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks quite sensible

Base automatically changed from feature/admin-improvements to master December 7, 2020 15:38
@ChrisMacNaughton
The settings page is divided into separate sections
befa40a 
B having separate sections for the different types of
settings, an administrator has a better experience
with managing EyeDP.

Closes #140
@ChrisMacNaughton
Update README to handle new settings locations
21824f1
@ChrisMacNaughton ChrisMacNaughton force-pushed the feature/admin-settings-split branch from 4cd1512 to 21824f1 Compare December 7, 2020 15:44
@ChrisMacNaughton ChrisMacNaughton merged commit 218973d into master Dec 7, 2020
@ChrisMacNaughton ChrisMacNaughton deleted the feature/admin-settings-split branch December 7, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igalic igalic igalic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EyeDP's admin settings page needs reworking to separate sections onto different pages

4 participants

@ChrisMacNaughton @coveralls @igalic