Password is a valid custom userdata type. #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the password custom data type, the value will be hashed using the same method as regular user password hashing before storing it in the database. This maintains alignment with integrations that may want to shift from using the password for a user to app specific passwords. Closes #291
ChrisMacNaughton
force-pushed
the
extra-attribute-validation
branch
from
c557128 to
cb3582c
Compare
ChrisMacNaughton
force-pushed
the
extra-attribute-validation
branch
from
37f24a3 to
99e117e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the password custom data type, the value will
be hashed using the same method as regular user password
hashing before storing it in the database. This maintains
alignment with integrations that may want to shift from
using the password for a user to app specific passwords.
Additionally, this reduces the necessity for brakeman ignores
by adding explicit validation for custom data types.
Closes #291