Add null checks#14
Merged
Merged
Conversation
Motivation ---------- Better exceptions with preconditions. Modifications ------------- Add a ThrowHelper for .NET < 6 and then use it or ArgumentNullException.ThrowIfNull.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds null checks for better exception handling with preconditions across the CenterEdge.Async library. The changes implement null validation for parameters in public API methods using framework-appropriate approaches.
- Creates a custom
ThrowHelperclass for .NET versions prior to 6.0 - Adds comprehensive null checks to all public
RunSyncmethods inAsyncHelper - Implements conditional compilation to use
ArgumentNullException.ThrowIfNullfor .NET 6+ or custom helper for older versions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ThrowHelper.cs | New internal helper class for throwing ArgumentNullException in pre-.NET 6 frameworks |
| CenterEdge.Async.csproj | Build configuration to exclude ThrowHelper.cs when targeting .NET 6+ |
| ExclusiveSynchronizationContext.cs | Adds null check for callback parameter in Post method |
| AsyncHelper.cs | Adds null checks to all six RunSync method overloads |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brant Burnett <bburnett@centeredgesoftware.com>
RobRobertsCE
previously approved these changes
Sep 29, 2025
RobRobertsCE
approved these changes
Sep 29, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Better exceptions with preconditions.
Modifications
Add a ThrowHelper for .NET < 6 and then use it or
ArgumentNullException.ThrowIfNull.