Conversation
Member
Author
|
FYI, includes your |
cubap
commented
Feb 18, 2022
| @@ -1,4 +1,5 @@ | |||
| require('dotenv').config() | |||
| import fetch from 'node-fetch' | |||
Member
Author
There was a problem hiding this comment.
something here is bad news bears and I had to comment it out for the moment in app.js
Member
There was a problem hiding this comment.
Yeah I noticed. That's OK, we will figure it out. It's a deep cut Node thing.
thehabes
approved these changes
Feb 21, 2022
thehabes
left a comment
thehabes
left a comment
Member
There was a problem hiding this comment.
The only thing I noticed is that you are using got for all your fetch moments. Is that something you hope we continue to use in the future? I am not using got in my code, for example. I am just using fetch()es.
Member
Author
|
yeah. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start the testing harness for TinyThings in Node with Jest.