Validate empty query body and improve errors#33
Merged
Conversation
Reject empty JSON query bodies ('{}' or '[]') with a 400 error to prevent accidental all-data queries. Also set a 400 status for invalid `limit`/`skip` inputs and propagate the error status and message in the response (res.status(err.status ?? 500).send("Caught " + err.message)). Adds clearer error creation and handling for client input validation.
thehabes
approved these changes
Mar 23, 2026
Member
thehabes
left a comment
thehabes
left a comment
There was a problem hiding this comment.
Tested locally and confirmed that POST /query {}, [], and bodies all have a 400 error with an appropriate message. Also confirmed that a body of actual null and undefined results in a 400, which is handled correctly by express.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject empty JSON query bodies ('{}' or '[]') with a 400 error to prevent accidental all-data queries. Also set a 400 status for invalid
limit/skipinputs and propagate the error status and message in the response (res.status(err.status ?? 500).send("Caught " + err.message)). Adds clearer error creation and handling for client input validation.