[SHARE-497][SHARE-526][Task] Add a status/version endpoint to the API#584
[SHARE-497][SHARE-526][Task] Add a status/version endpoint to the API#584
Conversation
| RUN python manage.py collectstatic --noinput | ||
|
|
||
| ARG GIT_TAG= | ||
| ARG GIT_COMMIT= |
There was a problem hiding this comment.
Is there a reason for the separate GIT_TAG and GIT_COMMIT? It looks like GIT_COMMIT is only used for release in sentry issues, and it looks like it's null. Seems like they could be the same thing?
There was a problem hiding this comment.
Mostly readability:
# git rev-parse HEAD
aeb92b8c98b9b2165b66f4ba2f866636743fec26
# git describe
2.3.1-16-gaeb92b8
The purpose of the endpoint is mostly to check that the latest release is actually whats released.
I don't really have strong feelings one way or the other. Do you have a preference?
(And I copied it from fakecas.)
There was a problem hiding this comment.
git describe is definitely better than the full commit hash. I don't have any feelings about GIT_COMMIT, it just seemed potentially redundant, and if it's only used for display (or not actually given a value?) could be replaced with GIT_TAG. 🤷♂️
laurenbarker
changed the title
chrisseto
force-pushed
the
feature/status
branch
from
85fd462 to
3fc4958
Compare
* In DEBUG mode, if VERSION is not set it will be pulled from a git
repo
* The Dockerfile now accepts GIT_TAG which will be passed in as
VERSION
* [SHARE-526] Also removes "Notify" from browsable API page title
chrisseto
force-pushed
the
feature/status
branch
from
3fc4958 to
b80fc3b
Compare
2 participants
repo
VERSION