[ENG-9827] - Revert metadata creation workflow#1000
Open
Vlad0n20 wants to merge 4 commits into
Open
Conversation
nsemets
requested changes
May 29, 2026
| }), | ||
| ]; | ||
| const apiFilterKeys = new Set(response.filters.map((f) => f.key)); | ||
| const merged = [...response.filters, ...extraFilters.filter((f) => !apiFilterKeys.has(f.key))]; |
Collaborator
There was a problem hiding this comment.
I hope it will not break anything in search.
| private readonly signpostingService = inject(SignpostingService); | ||
|
|
||
| readonly collectionSubmissionWithCedar = this.environment.collectionSubmissionWithCedar; | ||
| activeFlags = select(UserSelectors.getActiveFlags); |
Collaborator
There was a problem hiding this comment.
Suggested change
| activeFlags = select(UserSelectors.getActiveFlags); | |
| private readonly activeFlags = select(UserSelectors.getActiveFlags); |
Comment on lines
+59
to
+60
| collectionLicenses: { | ||
| ...state.collectionLicenses, |
Collaborator
There was a problem hiding this comment.
Why did you change it to collectionLicenses if it updates currentProjectSubmission below?
| if (!this.useShareTroveSearch() || !provider || !collectionId || this.defaultSearchFiltersInitialized()) return; | ||
|
|
||
| this.actions.setDefaultFilterValue('isContainedBy', provider.iri); | ||
| const collectionIri = `${this.environment.apiDomainUrl}/v2/collections/${collectionId}/`; |
Collaborator
There was a problem hiding this comment.
I am not sure if it is good idea to use like this. I prefer using iri from API data.
| data: { '@context': {} }, | ||
| id: 'template-1', | ||
| isPublished: true, | ||
| } as any; |
Collaborator
There was a problem hiding this comment.
Use correct model and not any.
| expect(store.dispatch).toHaveBeenCalledWith( | ||
| new CreateCedarMetadataRecord(MOCK_CEDAR_DATA, 'project-1', ResourceType.Project) | ||
| ); | ||
| expect(store.dispatch).toHaveBeenCalledWith(new CreateCollectionSubmission({ title: 'Submission' } as any)); |
Collaborator
There was a problem hiding this comment.
Use correct model here and not any. Also update other places with any.
| .subscribe({ | ||
| next: () => { | ||
| this.toastService.showSuccess('collections.removeDialog.success'); | ||
| this.loaderService.show(); |
Collaborator
There was a problem hiding this comment.
It needs to cover all ts code with unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes