[ENG-8505] Added the ability to get the oauth token for the GFP #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
Aug 27, 2025
...hared/components/addons/folder-selector/google-file-picker/google-file-picker.component.html
Outdated
Show resolved
Hide resolved
...hared/components/addons/folder-selector/google-file-picker/google-file-picker.component.html
Outdated
Show resolved
Hide resolved
.../shared/components/addons/folder-selector/google-file-picker/google-file-picker.component.ts
Show resolved
Hide resolved
.../shared/components/addons/folder-selector/google-file-picker/google-file-picker.component.ts
Outdated
Show resolved
Hide resolved
.../shared/components/addons/folder-selector/google-file-picker/google-file-picker.component.ts
Show resolved
Hide resolved
futa-ikeda
requested changes
Aug 27, 2025
Contributor
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
Most of this looks good to me. My biggest qualm is changing AuthorizedAddon to AuthorizedStorageAccountModel. I would prefer using the more general AuthorizedAddon in most of these cases, since the addons workflow should accomodate all addon types and using the storage-specific one is a bit misleading
src/app/features/project/addons/components/configure-addon/configure-addon.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/models/addons/authorized-storage-account.model.ts
Outdated
Show resolved
Hide resolved
bp-cos
force-pushed
the
feature/eng-8505-3
branch
from
1cd0e25 to
a2f06b1
Compare
nsemets
approved these changes
Aug 27, 2025
futa-ikeda
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added the ability to get the oauth token for the GFP
Summary of Changes
Added a new action, state method, selector and a service method
Updated the mapper and the models