Skip to content

[ENG-9227] Added counter for comment #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

[ENG-9227] Added counter for comment #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
923b301
fix(make-decision): added counter for comment
nsemets Oct 20, 2025
5d39ed5
Merge remote-tracking branch 'origin/feature/pbs-25.01' into fix/9227
nsemets Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .../components/preprint-details/preprint-make-decision/preprint-make-decision.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ <h4 class="line-height-3">{{ 'preprints.details.decision.decline.label' | transl
</section>

<section class="w-full">
<label for="withdrawalJustification">{{ labelRequestDecisionJustification() | translate }}</label>
<div class="flex justify-content-between align-items-center gap-4">
<label for="withdrawalJustification">{{ labelRequestDecisionJustification() | translate }}</label>
<p>{{ reviewerComment()?.length ?? 0 }}/{{ decisionCommentLimit }}</p>
</div>

<textarea
pTextarea
id="withdrawalJustification"
Expand Down Expand Up @@ -110,10 +114,12 @@ <h4 class="line-height-3">{{ rejectOptionLabel() | translate }}</h4>
</section>

<section class="w-full mt-4">
<p class="flex justify-content-end">{{ reviewerComment()?.length ?? 0 }}/{{ decisionCommentLimit }}</p>

<textarea
pTextarea
id="comment"
class="w-full"
class="w-full mt-1"
[placeholder]="'preprints.details.decision.commentPlaceholder' | translate"
[rows]="4"
[(ngModel)]="reviewerComment"
Expand Down
15 changes: 12 additions & 3 deletions ...features/registry/components/registry-make-decision/registry-make-decision.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,18 @@
</div>
</div>

<div class="flex gap-2">
<div class="flex flex-column gap-1">
<p class="flex justify-content-end">
{{ requestForm.controls[ModerationDecisionFormControls.Comment].value.length }}/{{ decisionCommentLimit }}
</p>

<textarea
pTextarea
[formControlName]="ModerationDecisionFormControls.Comment"
[placeholder]="'moderation.makeDecision.remarksPlaceholder' | translate"
[rows]="6"
[maxlength]="decisionCommentLimit"
class="w-full mt-3"
class="w-full"
></textarea>
</div>
} @else {
Expand All @@ -89,7 +93,12 @@
</label>
</div>
</div>
<div class="flex flex-column gap-2">

<div class="flex flex-column gap-1">
<p class="flex justify-content-end">
{{ requestForm.controls[ModerationDecisionFormControls.Comment].value.length }}/{{ decisionCommentLimit }}
</p>

<textarea
pTextarea
[formControlName]="ModerationDecisionFormControls.Comment"
Expand Down
12 changes: 8 additions & 4 deletions src/app/shared/components/make-decision-dialog/make-decision-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,28 +59,32 @@
</div>
}

<div class="flex gap-2">
<div class="flex flex-column gap-1 mt-3">
<p class="flex justify-content-end">
{{ requestForm.controls[ModerationDecisionFormControls.Comment].value.length }}/{{ decisionCommentLimit }}
</p>

<textarea
pTextarea
[formControlName]="ModerationDecisionFormControls.Comment"
[placeholder]="'moderation.makeDecision.remarksPlaceholder' | translate"
[rows]="6"
[maxlength]="decisionCommentLimit"
class="w-full mt-3"
class="w-full"
></textarea>
</div>

<div class="flex pt-3 gap-3 justify-content-between">
<p-button
[label]="'common.buttons.cancel' | translate"
severity="info"
(click)="dialogRef.close(false)"
(onClick)="dialogRef.close(false)"
[disabled]="isSubmitting()"
class="btn-full-width"
/>
<p-button
[label]="'moderation.makeDecision.submitDecision' | translate"
(click)="handleSubmission()"
(onClick)="handleSubmission()"
severity="success"
[loading]="isSubmitting()"
[disabled]="isSubmitDisabled"
Expand Down
Loading