Skip to content

[ENG-9224] Bibliographic author list should be displayed in reviews app, not just the creator #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

[ENG-9224] Bibliographic author list should be displayed in reviews app, not just the creator #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/features/moderation/store/preprint-moderation/preprint-moderation.state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export class PreprintModerationState {
);

return this.contributorsService
.getAllContributors(ResourceType.Preprint, preprintId, 1, DEFAULT_TABLE_PARAMS.rows)
.getBibliographicContributors(ResourceType.Preprint, preprintId, 1, DEFAULT_TABLE_PARAMS.rows)
.pipe(
tap((res) => {
ctx.setState(
Expand Down Expand Up @@ -241,7 +241,7 @@ export class PreprintModerationState {
);

return this.contributorsService
.getAllContributors(ResourceType.Preprint, preprintId, 1, DEFAULT_TABLE_PARAMS.rows)
.getBibliographicContributors(ResourceType.Preprint, preprintId, 1, DEFAULT_TABLE_PARAMS.rows)
.pipe(
tap((res) => {
ctx.setState(
Expand Down
32 changes: 23 additions & 9 deletions src/app/shared/services/contributors.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,16 @@ export class ContributorsService {
[ResourceType.DraftRegistration, 'draft_registrations'],
]);

private getBaseUrl(resourceType: ResourceType, resourceId: string): string {
private getBaseUrl(resourceType: ResourceType, resourceId: string, isBibliographic = false): string {
const resourcePath = this.urlMap.get(resourceType);

if (!resourcePath) {
throw new Error(`Unsupported resource type: ${resourceType}`);
}

return `${this.apiUrl}/${resourcePath}/${resourceId}/contributors`;
const contributorsUrl = isBibliographic ? 'bibliographic_contributors' : 'contributors';

return `${this.apiUrl}/${resourcePath}/${resourceId}/${contributorsUrl}`;
}

getAllContributors(
Expand All @@ -69,14 +71,26 @@ export class ContributorsService {
);
}

getRequestAccessContributors(resourceType: ResourceType, resourceId: string): Observable<ContributorModel[]> {
const resourcePath = this.urlMap.get(resourceType);
const baseUrl = `${this.apiUrl}/${resourcePath}/${resourceId}/requests/`;
const params = { 'embed[]': ['creator'] };
getBibliographicContributors(
resourceType: ResourceType,
resourceId: string,
page: number,
pageSize: number
): Observable<PaginatedData<ContributorModel[]>> {
const baseUrl = this.getBaseUrl(resourceType, resourceId, true);

return this.jsonApiService
.get<ContributorsResponseJsonApi>(baseUrl, params)
.pipe(map((response) => ContributorsMapper.getContributors(response.data)));
const params = {
page: page,
'page[size]': pageSize,
};

return this.jsonApiService.get<ContributorsResponseJsonApi>(`${baseUrl}/`, params).pipe(
map((response) => ({
data: ContributorsMapper.getContributors(response.data),
totalCount: response.meta.total,
pageSize: response.meta.per_page,
}))
);
}

searchUsers(value: string, page = 1): Observable<PaginatedData<ContributorAddModel[]>> {
Expand Down
Loading