Skip to content

Conversation

@nsemets
Copy link
Collaborator

@nsemets nsemets commented Oct 22, 2025

  • Ticket: [ANG-9250]
  • Feature flag: n/a

Summary of Changes

  1. Fixed display of schema blocks.

@nsemets nsemets requested a review from futa-ikeda October 22, 2025 15:04
Comment on lines +36 to +41
@if (page.questions?.length) {
<osf-registration-blocks-data
[questions]="page.questions"
[reviewData]="schemaResponseRevisionData()"
></osf-registration-blocks-data>
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for posterity, this addresses an issue where certain questions were not showing up in the overview page. This was stemming from the fact that there was an implicit assumption in how we were rendering forms before where we assumed the blocks would show up in an order like PageHeading -> SectionHeading -> QuestionLabel, but that is not necessarily the case

@nsemets
Copy link
Collaborator Author

nsemets commented Oct 22, 2025

Leaving a note here to describe the problem for ourselves in the future. The issue that was appearing was that certain sections of the registration template would not appear in the submission and the overview page

Missing sections on the submission page:

This issue would occur when multiple, back-to-back paragraph block types were in a template. The subsequent paragraph blocks would override the contents of the previous paragraph block that was stored in currentSection.description. The fix is to append the paragraph content to the existing description
Missing sections in the review and overview pages:

This issue was caused by the fact that there was a subtle assumption being made when rendering that schemas would follow the pattern of PageHeading -> SectionHeading -> QuestionLabel, but schemas may just go PageHeading -> QuestionLabel directly (skipping SectionHeading)

@nsemets nsemets merged commit d61483a into CenterForOpenScience:feature/pbs-25.02 Oct 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants