-
Notifications
You must be signed in to change notification settings - Fork 23
[ENG-9548] fix(wiki-list): Make rename wiki #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brianjgeiger
merged 3 commits into
CenterForOpenScience:feature/pbs-25.04
from
bodintsov:fix/unable-to-rename-wiki
Nov 6, 2025
Merged
[ENG-9548] fix(wiki-list): Make rename wiki #738
brianjgeiger
merged 3 commits into
CenterForOpenScience:feature/pbs-25.04
from
bodintsov:fix/unable-to-rename-wiki
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
requested changes
Nov 3, 2025
src/app/shared/components/wiki/rename-wiki-dialog/rename-wiki-dialog.component.ts
Show resolved
Hide resolved
src/app/shared/components/wiki/wiki-list/wiki-list.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/components/wiki/wiki-list/wiki-list.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/components/wiki/rename-wiki-dialog/rename-wiki-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/wiki/rename-wiki-dialog/rename-wiki-dialog.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/wiki/rename-wiki-dialog/rename-wiki-dialog.component.ts
Outdated
Show resolved
Hide resolved
nsemets
reviewed
Nov 4, 2025
src/app/shared/components/wiki/rename-wiki-dialog/rename-wiki-dialog.component.spec.ts
Outdated
Show resolved
Hide resolved
nsemets
reviewed
Nov 4, 2025
Collaborator
nsemets
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix comments.
nsemets
previously approved these changes
Nov 4, 2025
brianjgeiger
approved these changes
Nov 6, 2025
49e2652
into
CenterForOpenScience:feature/pbs-25.04
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable to rename a wiki
Summary of Changes
Enable to rename a wiki
Screenshot(s)
Side Effects
TBD
QA Notes
TBD