Skip to content

Code improvements #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

Code improvements #740

merged 2 commits into from
Nov 3, 2025

Conversation

@nsemets
Copy link
Collaborator

@nsemets nsemets commented Nov 3, 2025

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

  1. Add missing destroyReffor takeUntilDestroyed.
  2. Renamed analytics service to avoid duplication of services.

@nsemets nsemets requested a review from brianjgeiger November 3, 2025 17:53
@brianjgeiger brianjgeiger merged commit f193b2b into CenterForOpenScience:feature/pbs-25.03 Nov 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nsemets @brianjgeiger