[ENG-9242] Fix wrong < > & encoding #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
Nov 4, 2025
| <section class="flex flex-column gap-2"> | ||
| <h3> | ||
| {{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }} | ||
| {{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }} eeee |
Collaborator
There was a problem hiding this comment.
Suggested change
| {{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }} eeee | |
| {{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }} |
nsemets
reviewed
Nov 4, 2025
| if (titleTag?.attrs.content) { | ||
| this.title.setTitle(`${String(this.defaultMetaTags.siteName)} | ${String(titleTag.attrs.content)}`); | ||
| const title = `${String(this.defaultMetaTags.siteName)} | ${String(titleTag.attrs.content)}`; | ||
| this.title.setTitle(FixSpecialCharPipe.prototype.transform(title)); |
Collaborator
There was a problem hiding this comment.
It is bad practice to use prototype. First inject pipe and then use it.
Here is code: private readonly fixSpecialCharPipe = inject(FixSpecialCharPipe);
this.title.setTitle(this.fixSpecialCharPipe.transform(title));
nsemets
approved these changes
Nov 4, 2025
brianjgeiger
merged commit 238adb4
into
CenterForOpenScience:feature/pbs-25.03
3 checks passed
mkovalua
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix wrong < > & encoding
Summary of Changes
Fix wrong < > & encoding
Screenshot(s)
Side Effects
QA Notes