Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

  • Ticket: [ENG-8553]
  • Feature flag: n/a

Purpose

  • fix bug present when users try to upload a file when creating new preprint version

Summary of Changes

  • Remove a potentially redundant request to rename a file
    • There is a request that was going to WaterButler to rename the existing preprint file after a user updates an existing preprint file. This rename request would error if a user uploaded a file with the same name as the existing preprint file

Screenshot(s)

Side Effects

QA Notes

  • This PR should fix the scenario where a user uploads a file with the same name to a preprint version
  • If there are any other scenarios which lead to this bug where a file upload for a preprint fails, please let me know

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 55.527% (-0.007%) from 55.534%
when pulling d21660e on futa-ikeda:fix/eng-8553
into 605da4c on CenterForOpenScience:develop.

nsemets
nsemets previously approved these changes Nov 26, 2025
@nsemets
Copy link
Collaborator

nsemets commented Nov 26, 2025

@futa-ikeda Just need to change branch to new another one.

@futa-ikeda futa-ikeda changed the base branch from develop to main November 26, 2025 14:17
@futa-ikeda futa-ikeda dismissed nsemets’s stale review November 26, 2025 14:17

The base branch was changed.

@adlius adlius changed the base branch from main to hotfix/25.4.1 November 26, 2025 14:32
@adlius adlius merged commit 8cff26f into CenterForOpenScience:hotfix/25.4.1 Nov 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants