Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Dec 3, 2025

  • Ticket: [ENG-9072]
  • Feature flag: n/a

Purpose

  • Fix accessibility issue with search cards having nested interactive controls

Summary of Changes

  • Move <p-accordion-header> closing tag to just enclose the top section of the search result card
  • Diff best viewed with whitespace ignored

Screenshot(s)

Side Effects

QA Notes

  • Running an accessibility scan of this page using the Axe devtool should have 10 less "Interactive controls must not be nested" errors. (15 -> 5 with 5 still on the navbar)

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 55.527%. remained the same
when pulling 59026e1 on futa-ikeda:fix/eng-9072
into 358cbf5 on CenterForOpenScience:develop.

@nsemets
Copy link
Collaborator

nsemets commented Dec 4, 2025

@futa-ikeda Some styles changed after your update. It’s better to keep them the same as before.

Before changes:
image

After changes:
image

@nsemets nsemets changed the base branch from develop to feature/pbs-25-24 December 5, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants