fix(ENG-10262): fixed login url encoding#886
Merged
nsemets merged 2 commits intoCenterForOpenScience:feature/osf4i-in-progress-ssofrom Feb 18, 2026
Merged
Conversation
nsemets
approved these changes
Feb 18, 2026
nsemets
merged commit f3707fa
into
CenterForOpenScience:feature/osf4i-in-progress-sso
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openscience.atlassian.net/browse/ENG-10262
Purpose
For LOCAL env only:
A new
nextquery parameter must be the first one to be encrypted and then encrypted one more time withservicequery parameter together.So everything after
localhost:8080/login?service=is encrypted and thenextquery param with its value is encrypted twice.Also in the middle of the url, we should use
?instead of&(%3F - encoded, between login and next words) so that thenextparameter belongs toservice, not the main requesthttp://192.168.168.167:8080/login?service=http%3A%2F%2Flocalhost%3A5000%2Flogin%3Fnext%3Dhttp%253A%252F%252Flocalhost%253A4200%252F
And CAS should handle login, not angular, so we replace 4200 port in
servicequery parameter by 5000