-
Notifications
You must be signed in to change notification settings - Fork 42
[EOSF-881] Fix contrast issue for error pages. #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EOSF-881] Fix contrast issue for error pages. #487
Conversation
jamescdavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe this change in the [unreleased] section of CHANGELOG.md
|
CHANGELOG.md is modified. |
|
This looks good. One small concern, and this seems to be intended, but if so we should be more explicit about it. Replacing |
|
You're right. The side effect is that the brands cannot customize how they want the error page to look like without also changing the header elements. This should be more favorable as it results in more consistent looks. If that is the case, I can go and remove that from the CSS files for brands. |
|
I honestly prefer the button solution, to keep brands' themes consistent. However, that is inconsistent UI with our other support links, inconsistent UX to what buttons normally do versus anchor tags, and it might look ugly. Also, its not like all our brands have great themes (cough cough agrixiv). So, I'm happy with just removing the CSS pertinent to error pages from those files and the brand template. |
48d172b
into
CenterForOpenScience:release/post-review-actions
Purpose
Currently, the color contrast for support email link on ECSarxiv and EarthArxiv error pages are not enough. This PR fix the issue.
Summary of Changes
Change the component's CSS class to 'prerpint-header' and 'preprint-hearder-error'.
Added a style file to the component to add padding and bottom margin.
Side Effects / Testing Notes
The error page for OSF preprint would also be changed to using the background image on the landing page, which should be more consistent.
Ticket
https://openscience.atlassian.net/browse/EOSF-881
Reviewer Checklist
CHANGELOG.md