Skip to content

[No ticket]Fix metadata panel for registry overview page for tablet view #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

[No ticket]Fix metadata panel for registry overview page for tablet view #1182

merged 1 commit into from
Apr 15, 2021

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Apr 14, 2021 •
edited
Loading

  • Ticket: [No ticket]
  • Feature flag: n/a

Purpose

Fix tablet view of the metadata panel for registration overview page

Summary of Changes

  • remove unneeded style

Screenshots

Before:
Screen Shot 2021-04-14 at 5 26 32 PM

After:
Screen Shot 2021-04-14 at 5 26 42 PM

Side Effects

  • There should be none... I think this style was added in by mistake to begin with

QA Notes

  • for tablets (or for mobile if the screen is landscape), there should no longer be the weird background-less view for the metadata panel

@futa-ikeda futa-ikeda merged commit 830b80e into CenterForOpenScience:develop Apr 15, 2021
@fabmiz fabmiz added this to the 21.3.0 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

+1 more reviewer

@fabmiz fabmiz fabmiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

21.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@futa-ikeda @fabmiz @brianjgeiger